Prevent 404 HTTP code from throwing an exception #4446
Conversation
debug/index.html
Outdated
| }, | ||
| center: [-120.8, 39.1], // starting position | ||
| zoom: 11 // starting zoom | ||
|
|
There was a problem hiding this comment.
do you want to add this permanently? I'd prefer to keep debug page simple but open to arguments 😊
There was a problem hiding this comment.
Oopsie. I meant to overwrite this before pushing.
| @@ -165,7 +165,7 @@ class SourceCache extends Evented { | |||
| _tileLoaded(tile, id, previousState, err) { | |||
| if (err) { | |||
| tile.state = 'errored'; | |||
| this._source.fire('error', {tile: tile, error: err}); | |||
| if (err.status !== 404) this._source.fire('error', {tile: tile, error: err}); | |||
There was a problem hiding this comment.
are there any other cases in which a tile error would 404 for a legitimate reason besides no data in the tile (and thus no tile) ? Should we check the message matches 'Error: not found' ?
There was a problem hiding this comment.
The 404 status code strongly implies the "Not found" status text.
I cannot imagine any cases in which a custom status message on a 404 response would necessitate different error handling. If we discover one in the future, we can accommodate it then. 😄
src/source/vector_tile_source.js
Outdated
| @@ -87,7 +87,8 @@ class VectorTileSource extends Evented { | |||
| return; | |||
|
|
|||
| if (err) { | |||
| return callback(err); | |||
| if (err.status !== 404) callback(err); | |||
There was a problem hiding this comment.
but do we still need to call the callback (w/o err) if the tile is not found?
There was a problem hiding this comment.
Yup. The latest version of this file didn't get pushed either. Fixed now.
| super(message); | ||
| this.status = status; | ||
| } | ||
| } |
|
Hi. I think there's a problem with completely preventing the expception. If you are waiting for the "idle" event and the 404 error prints on the browser, the idle event does not fire, so my program keeps hanging. Having the exception would allow my program to move on. Is there a workaround to this? |
This PR prevents throwing an exception when a tile request yields a 404 HTTP status code. It also minorly improves our test coverage of the
ajax.jsutil module.Fixes #1800
Launch Checklist