skip pattern layer when pattern is missing #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
May 8, 2017
src/render/draw_fill_extrusion.js
Outdated
| @@ -151,6 +151,7 @@ function drawExtrusion(painter, source, layer, coord) { | |||
| programConfiguration.setUniforms(gl, program, layer, {zoom: painter.transform.zoom}); | |||
|
|
|||
| if (image) { | |||
| if (pattern.isPatternMissing(layer.paint['fill-extrusion-pattern'], painter)) return; | |||
There was a problem hiding this comment.
Nit: layer.paint['fill-extrusion-pattern'] ⇢ image
No error or warning is printed for missing patterns. fix #4660
ansis
force-pushed
the
4660-fix-pattern-flicker
branch
from
2befc33
to
3261d29
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where pattern layers were rendered even if the needed pattern wasn't loaded and bound. The missing texture would render as a black area.
No error or warning will be emitted for missing patterns. Is this the correct behavior? This seems consistent with missing symbol icons.
fix #4660
benchmarks
Launch Checklist