Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split "curve" into "step" and "interpolate" #5542

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Split "curve" into "step" and "interpolate" #5542

merged 2 commits into from
Oct 31, 2017

Conversation

jfirebaugh
Copy link
Contributor

Fixes #5528. Will make sure all the right people get a heads up before this is merged.

@jfirebaugh jfirebaugh mentioned this pull request Oct 27, 2017
Closed
@jfirebaugh jfirebaugh force-pushed the curve-step-interpolate branch from f95f06c to 2d3a54a Compare October 27, 2017 19:00
@jfirebaugh
Copy link
Contributor Author

Blocked on posting benchmark results by #5543.

anandthakker
anandthakker approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

My only question: should we add a "curve" alias (with a loud deprecation warning) and thus postpone the breaking change by one version?

@mourner
Copy link
Member

mourner commented Oct 30, 2017

@anandthakker I'd say no, better break hard early. Alias would be good to help with the transition, but there's not enough adoption of expressions yet to delay the break.

@jfirebaugh jfirebaugh force-pushed the curve-step-interpolate branch from 2d3a54a to 8fb99f5 Compare October 30, 2017 17:48
@jfirebaugh
Copy link
Contributor Author

I kept it an error, but with a custom error message indicating the new operators.

@jfirebaugh jfirebaugh force-pushed the curve-step-interpolate branch from 85d06c3 to ecc92b5 Compare October 30, 2017 18:53
@jfirebaugh jfirebaugh force-pushed the curve-step-interpolate branch from ecc92b5 to 646fca8 Compare October 31, 2017 04:31
@jfirebaugh
Copy link
Contributor Author

https://bl.ocks.org/anonymous/raw/0faddf4a07f92862b32b0d2dfeff39bf/ (no significant changes)

@jfirebaugh jfirebaugh merged commit 25e5f1d into master Oct 31, 2017
@jfirebaugh jfirebaugh deleted the curve-step-interpolate branch October 31, 2017 17:23
@jfirebaugh jfirebaugh added this to the v0.42 milestone Nov 2, 2017
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
@lucaswoj lucaswoj mentioned this pull request Mar 12, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandthakker anandthakker anandthakker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.42
Development

Successfully merging this pull request may close these issues.
3 participants
@jfirebaugh @mourner @anandthakker