Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone property values on input and output #5806

Merged
merged 1 commit into from
Dec 5, 2017
Merged

Clone property values on input and output #5806

merged 1 commit into from
Dec 5, 2017

Conversation

jfirebaugh
Copy link
Contributor

Fixes #5802.

@jfirebaugh
Clone property values on input and output
b1f0df4 
This allows programs to mutate them internally -- a questionable practice, but supported by previous versions.
@jfirebaugh jfirebaugh requested a review from mollymerp December 5, 2017 00:03
mollymerp
mollymerp approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good thank you!

@jfirebaugh jfirebaugh merged commit b860950 into master Dec 5, 2017
@jfirebaugh jfirebaugh deleted the fix-5802 branch December 5, 2017 18:57
@jfirebaugh jfirebaugh mentioned this pull request Dec 14, 2017
Merged
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @mollymerp