Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popup open event #6311

Merged
merged 2 commits into from
Mar 10, 2018
Merged

Add popup open event #6311

merged 2 commits into from
Mar 10, 2018

Conversation

jmeyers91
Copy link
Contributor

This PR adds the 'open' event to popups when they're added to a map.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

jfirebaugh
jfirebaugh approved these changes Mar 10, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@jfirebaugh jfirebaugh merged commit f94e1f9 into mapbox:master Mar 10, 2018
@jfirebaugh jfirebaugh mentioned this pull request Mar 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeyers91 @jfirebaugh