-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework spec function/expression taxonomy (recreate #6505) #6521
Conversation
7504d50
to
f5aa39f
Compare
@samanpwbb @anandthakker @jfirebaugh @1ec5 requesting review from anyone based on the new additions to this since #6505 (noted at the top of OP) — format + language of the |
I don't think we should add these to the documentation. We already have fairly complex terminology surrounding properties ("layout", "paint", "function", "expression", "interpolatable", "data expression", "camera expression", ...), and I don't think additional terminology is going to clarify the situation. Let's keep these types as an implementation detail. |
Ports mapbox/mapbox-gl-js#6521: for the sake of gl-native this only requires tweak to code generation scripts.
Ports mapbox/mapbox-gl-js#6521, updating codegen scripts to parse new expression taxonomy.
Recreates #6505 — I reverted until I have a gl-native PR ready, as it'll otherwise cause a lot of code generation errors for the next person who tries to update the gl-js pin there.
New since #6505 I've also added a list of property-types and descriptor docs in a75b518[reverted]This PR reworks the taxonomy to describe how a property can use functions/expressions, as described in #6389 (comment) and #6389 (comment):
so now any property all properties include a
property-type
key, and for all property-types exceptconstant
also anexpression
property, i.e.Benchmarks: http://bl.ocks.org/lbud/raw/2ac3b8869074c112802166978cea8345/ (I couldn't reproduce the Layer discrepancies on subsequent isolated bench runs).
Closes #6389
Supersedes / closes #4194
Refs #6430
Refs #6303
Launch Checklist