fix #6548, never group symbol layers by layout #6556
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisLoer this is a possible fix for #6548 and alternative to #6550
Instead of storing
CrossTileIDs
per-layer this just makes it so that symbol buckets never have more than one layer. The layer grouping is an attempted optimization to reduce bucket creation time but this doesn't really matter for symbol layers because there aren't really very many (any?) production uses for having multiple layers with the same layout properties.EDIT: at first this seemed like a nicer approach than #6550 but I'm starting to lean back towards #6550. The other pr seems like a cleaner more logical exception, but this approach could possibly avoid some future bugs from layer sharing.
Launch Checklist