Don't load FeatureIndex#vtLayers from outside FeatureIndex code. #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #6555 (a possible crash when calling queryRenderedFeatures after querySourceFeatures) The actual contents of the regression test are not that important -- before this fix, the test would crash.
|
I fixed the |
|
@ChrisLoer Can you please backport this to the 0.45 release branch? |
ChrisLoer
added a commit
that referenced
this pull request
Apr 30, 2018
Don't load FeatureIndex#vtLayers from outside FeatureIndex code. (#6559) * Don't load FeatureIndex#vtLayers from outside FeatureIndex code. Fixes issue #6555 (a possible crash when calling queryRenderedFeatures after querySourceFeatures) The actual contents of the regression test are not that important -- before this fix, the test would crash. * Fix Tile unit test by deserializing the FeatureIndex before using it.
ChrisLoer
added a commit
that referenced
this pull request
Apr 30, 2018
Don't load FeatureIndex#vtLayers from outside FeatureIndex code. (#6559) * Don't load FeatureIndex#vtLayers from outside FeatureIndex code. Fixes issue #6555 (a possible crash when calling queryRenderedFeatures after querySourceFeatures) The actual contents of the regression test are not that important -- before this fix, the test would crash. * Fix Tile unit test by deserializing the FeatureIndex before using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6555 (a possible crash when calling queryRenderedFeatures after querySourceFeatures)
The actual contents of the regression test are not that important -- before this fix, the test would crash.
The problem was that
vtLayerswould be loaded without loading thesourceLayerCoder, and the FeatureIndex would assume both were loaded ifvtLayerswas loaded.I've checked and this doesn't appear to have an analog on gl-native.
/cc @ansis @mollymerp @andrewharvey