Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style-spec build #6575

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Fix style-spec build #6575

merged 1 commit into from
Apr 30, 2018

Conversation

anandthakker
Copy link
Contributor

@anandthakker anandthakker commented Apr 27, 2018 •
edited
Loading

  • Fix yarn build looking for rollup in src/style-spec/node_modules
  • Don't reuse the rollup plugins from the main build (specifically, this included "minifying" the style spec json by stripping out doc: fields

@anandthakker anandthakker requested a review from jfirebaugh April 27, 2018 22:07
@anandthakker anandthakker merged commit 25f9afa into master Apr 30, 2018
@anandthakker anandthakker deleted the fix-stylespec-build branch April 30, 2018 13:53
anandthakker added a commit that referenced this pull request May 3, 2018
@anandthakker
Fix style-spec build (#6575)
3f43d80
anandthakker added a commit that referenced this pull request May 3, 2018
@anandthakker
Cherry pick style-spec build fixes from master (#6603)
3bd1803 
* Fix style-spec build (#6575)

* Ensure style-spec is published with mapbox-gl (#6586)

Cherry pick 478dd56 from master

* Ensure style spec is published with build

Closes #6433
Closes #6574

* Consolidate build unit test commands

* Workaround CI image path bash/sh issue

mapbox/mbgl-ci-images#17

* Bump style-spec version to 12.0.0-pre.1 (#6595)

* Use named exports in style-spec.js (#6602)

Cherry pick e83054f from master

Fixes #6601

* Ignore whole /dist/ directory

Done in master with e83054f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anandthakker @jfirebaugh