Add rel="noopener" to Mapbox attribution link. #6729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorbypark
changed the title
|
Did this get removed? |
|
@doyle-mark No, but it was expanded by #8106 to include If you're seeing a problem, you can open a new issue with a description and a minimal reproduction of the bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Added a rel="noopener" attribute to the Mapbox attribution link. This is a Google Lighthouse Report "best practice", see here for details. In short, it makes target="_blank" links open in their own process, instead of sharing a process with the parent window.
yarn testpasses and Lighthouse Labs doesn't complain about the target="_blank" link not having the rel attribute set anymore.