Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel pending requests on map.remove() #6826

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Cancel pending requests on map.remove() #6826

merged 1 commit into from
Jun 18, 2018

Conversation

jfirebaugh
Copy link
Contributor

Fixes #6756.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

Copy link
Contributor

@anandthakker anandthakker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started thinking about how we could avoid the possibility of regressing this by forgetting to save and handle some Cancelable, but the only thing I could think of was having some kind AsyncManager container type that all cancellable-producing methods require as an argument, which would be overkill

@@ -0,0 +1,3 @@
// @flow

export type Cancelable = { cancel: () => void };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad there isn't something like Rust's must_use attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfirebaugh jfirebaugh merged commit e71c5e9 into master Jun 18, 2018
@jfirebaugh jfirebaugh deleted the fix-6756 branch June 18, 2018 16:19
@jfirebaugh jfirebaugh mentioned this pull request Jul 17, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants