Support collators in feature filter expressions. #6929
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6920: feature filters using collator expressions would incorrectly be treated as legacy filters.
This was a pretty easy piece of functionality to miss when adding the
collator
expression, since it's separate from the rest of the expression code. Is there a way we could surface the legacy feature filter support more, or automatically test it against new expressions? Or is it reasonable to say this won't happen very often because most expression work won't overlap with the legacy filter syntax?document any changes to public APIspost benchmark scoresmanually test the debug pagetagged@mapbox/studio
and/or@mapbox/maps-design
if this PR includes style spec changes/cc @anandthakker @1ec5