Support collators in feature filter expressions. #6929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #6920: feature filters using collator expressions would incorrectly be treated as legacy filters.
ChrisLoer
force-pushed
the
collator-filters
branch
from
7b8c952
to
8b2f3d7
Compare
jfirebaugh
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6920: feature filters using collator expressions would incorrectly be treated as legacy filters.
This was a pretty easy piece of functionality to miss when adding the
collatorexpression, since it's separate from the rest of the expression code. Is there a way we could surface the legacy feature filter support more, or automatically test it against new expressions? Or is it reasonable to say this won't happen very often because most expression work won't overlap with the legacy filter syntax?document any changes to public APIspost benchmark scoresmanually test the debug pagetagged@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes/cc @anandthakker @1ec5