Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up fixes for atlas packing #7253

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Follow-up fixes for atlas packing #7253

merged 2 commits into from
Sep 7, 2018

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 7, 2018

I don't have a way to test on IE11, but let's check if this fixes #7241.

@mourner mourner requested a review from jfirebaugh September 7, 2018 14:29
jfirebaugh
jfirebaugh approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@jfirebaugh jfirebaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in an IE11 VM.

@mourner
Copy link
Member Author

mourner commented Sep 7, 2018

Thanks a lot for confirming!

@mourner mourner merged commit 63a9f47 into master Sep 7, 2018
@mourner mourner deleted the atlas-ie-fixes branch September 7, 2018 17:59
@jfirebaugh jfirebaugh mentioned this pull request Sep 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfirebaugh jfirebaugh jfirebaugh approved these changes

Assignees
No one assigned
Labels
bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gl.texImage2D "Invalid argument" in IE 11
3 participants
@mourner @jfirebaugh @mollymerp