deregister marker mouseup and touchend when removing marker #7442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have run into scenarios where we remove a draggable marker before
mouseup
is ever fired and, because mouseup/touchend never fired once,_onUp
is called but the marker has already been torn down, leading to errors.Ensuring these listeners are deregistered when tearing down the marker will ensure that doesn't happen.
I didn't see any tests in the marker unit test file that ensure that listeners are being deregistered, so I did not add any tests with this. Let me know if I missed anything.Tests added.