Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom attribution strings in compact mode #7444

Merged
merged 2 commits into from
Oct 19, 2018
Merged

Fix custom attribution strings in compact mode #7444

merged 2 commits into from
Oct 19, 2018

Conversation

mollymerp
Copy link
Contributor

Fix #7440

Custom attribution strings weren't declared as HTML elements, and therefore were not hidden by the compact attribution CSS

verified in IE and FF:
image

image

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

@mollymerp mollymerp requested a review from ryanhamley October 18, 2018 21:40
@mollymerp mollymerp changed the title Custom compact attrib Fix custom attribution strings in compact mode Oct 18, 2018
ryanhamley
ryanhamley approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mollymerp mollymerp merged commit 4a07a87 into master Oct 19, 2018
@mollymerp mollymerp deleted the custom-compact-attrib branch October 19, 2018 00:58
@mourner mourner mentioned this pull request Nov 3, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhamley ryanhamley ryanhamley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mollymerp @ryanhamley