Stub local and session storage in JSDOM #7516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be desirable to upgrade JSDom along with this? |
There was a problem hiding this comment.
@ryanhamley Would a stub implementation with an exception be better than deleting the properties? It would help debug if new code relied on either of these.
|
I've updated |
asheemmamoowala
approved these changes
Oct 31, 2018
ryanhamley
changed the title
Merged
asheemmamoowala
pushed a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
This replaces #7455
JSDOM 11.12 introduced the
localStorageAPI. Our codebase copies properties from one JSDOM instance to another which worked fine but when accessinglocalStoragein a Node context where the JSDOM's base URL is not set, an error is thrown.localStorageis not used in our tests (we stub it out in a couple of places) so I think this is probably an acceptable workaround. Setting the JSDOM's base URL can cause issues with some tests and creates potential CORS errors that makes testing a pain.Tip of the 🎩 to @fc for reporting the original bug and helping figure out what exactly was going wrong.