Use 1px border for DEM backfilling #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
This looks great to me — thanks a lot for the PR!
@mollymerp anything that could possibly break with this change?
|
yes – we initially were going to use mipmapping for the "openness" visualization, but had to scrub that because of hardware issues on some devices but the original power-of-two constraint snuck in. I don't think this should cause any problems. I have ported this over to gl-native here mapbox/mapbox-gl-native#13550 thanks! |
6 tasks
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 14, 2019
pirxpilot
pushed a commit
to pirxpilot/mapbox-gl-js
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the empty 256 pixels of padding around DEM data. This padding means that the DEMData array buffer is ~4x as big as it needs to be, and we're uploading a ~4x demTexture to the GPU. A one pixel border is all we need for DEM backfilling. The demTexture is not mipmapped so I don't think it needs to be a power-of-two texture. A quick look at Chrome Dev Tools shows a big drop in memory usage on the hillshade debug page (119MB to 47MB). Benchmarks don't show anything notable.
Launch Checklist