Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeFeatureState #7761

Merged
merged 1 commit into from
Jan 23, 2019
Merged

removeFeatureState #7761

merged 1 commit into from
Jan 23, 2019

Conversation

peterqliu
Copy link
Contributor

retry of #7696

retry of #7669

Addresses #6889

Depending on parameters specified, enables feature state removal at the source, feature, and property levels.

screen shot 2018-12-11 at 1 35 34 pm

screen shot 2018-12-11 at 1 36 02 pm

screen shot 2018-12-11 at 1 39 01 pm

Effect on setFeatureState perf:

screen shot 2018-12-10 at 4 20 54 pm

cc/ @asheemmamoowala

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@peterqliu peterqliu mentioned this pull request Jan 10, 2019
Closed
5 tasks
asheemmamoowala
asheemmamoowala suggested changes Jan 10, 2019
View reviewed changes
src/ui/map.js Outdated Show resolved Hide resolved
src/ui/map.js Show resolved Hide resolved
test/unit/ui/map.test.js Outdated Show resolved Hide resolved
test/unit/ui/map.test.js Show resolved Hide resolved
test/unit/ui/map.test.js Show resolved Hide resolved
test/unit/ui/map.test.js Outdated Show resolved Hide resolved
test/unit/ui/map.test.js Outdated Show resolved Hide resolved
test/unit/ui/map.test.js Show resolved Hide resolved
src/style/style.js Outdated Show resolved Hide resolved
asheemmamoowala
asheemmamoowala approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@peterqliu peterqliu merged commit b01a5d3 into master Jan 23, 2019
@asheemmamoowala asheemmamoowala deleted the rFS-v3 branch January 23, 2019 23:21
@asheemmamoowala asheemmamoowala mentioned this pull request Jan 23, 2019
Closed
@ghost ghost mentioned this pull request Oct 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterqliu @asheemmamoowala