Fix Safari bug which mistakenly requested WebP images #7817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
reviewed
Jan 25, 2019
| // after a successful image load event | ||
| if (webpImgTestOnloadComplete) { | ||
| testWebpTextureUpload(gl); | ||
| } |
There was a problem hiding this comment.
I think there is still a possible race condition here. testSupport could run when the image has successfully loaded (webpImgTest.complete === true) but onload has not run yet. In this case testWebpTextureUpload would never run and it would never start loading webps. That isn't as bad as loading then when we shouldn't but it might be good to fix.
I think this could be fixed by adding
} else {
glForTesting = gl;
}
here and removing the if (!webpImgTest.complete) { section completely.
There was a problem hiding this comment.
I think I pushed the changes you're asking for
ryanhamley
added a commit
that referenced
this pull request
Jan 25, 2019
ryanhamley
added a commit
that referenced
this pull request
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
I uncovered a bug while testing iOS Safari in which WebP images would occasionally be requested. This PR fixes that bug by waiting until the image's onload event fires to check for WebP support.
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changes