Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return clone instead of a reference on map.getCenter() #3610 #7922

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Return clone instead of a reference on map.getCenter() #3610 #7922

merged 2 commits into from
Feb 18, 2019

Conversation

stepankuzmin
Copy link
Contributor

Return clone instead of a reference on map.getCenter() according to #3610
Is it correct to use util.clone in this case?

  • briefly describe the changes in this PR
  • manually test the debug page

@stepankuzmin
Copy link
Contributor Author

I've changed util.clone to new LngLat().

asheemmamoowala
asheemmamoowala approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #3610 .

@asheemmamoowala asheemmamoowala merged commit 0a1aeda into mapbox:master Feb 18, 2019
@stepankuzmin stepankuzmin deleted the 3610 branch February 19, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepankuzmin @asheemmamoowala