Enable local ideograph generation by default #8008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graphs' and 'Hangul Syllables' ranges, using the system default sans-serif font.
mourner
requested changes
Mar 9, 2019
mourner
approved these changes
Mar 13, 2019
|
|
||
| } else if (operation[0] === 'setStyle') { | ||
| map.setStyle(operation[1], { localIdeographFontFamily: false }); | ||
| applyOperations(map, operations.slice(1), callback); |
There was a problem hiding this comment.
Nit: let's add a comment here about why this is necessary.
asheemmamoowala
force-pushed
the
enable-localIdeographs
branch
from
5fc3acb
to
7dd11fa
Compare
asheemmamoowala
force-pushed
the
enable-localIdeographs
branch
from
7dd11fa
to
e2b3825
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable local ideograph generation for glyphs in the 'CJK Unified Ideographs' and 'Hangul Syllables' ranges, using the system default sans-serif font.
I haven't been able to find a good way to add tests for this PR. The glyph rendering depends on a font being consistently available on the system. While a font can be installed on the docker containers for CI, it would also have to be made available for every developer running the test locally.
@mapbox/studio @mapbox/maps-design This change affects GL-JS by default, so for designers in Studio working on styling with custom fonts - it might be useful think of some messaging if the map is bringing in data in those glyph ranges, or the map is hovering over data in that range.
Launch Checklist
@mapbox/studioand/or@mapbox/maps-designif this PR includes style spec changescc @ChrisLoer 👋 @chloekraw @lloydsheng @chriswu42