-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve single vs. multi-touch zoom & pan interaction (#7196) #8100
Commits on Mar 29, 2019
-
Pass empty touches list in simulated touchend/touchcancel
to reflect how we usually expect these events to look
Anjana Vakil committedMar 29, 2019 Configuration menu - View commit details
-
Copy full SHA for 3a8bde2 - Browse repository at this point
Copy the full SHA 3a8bde2View commit details
Commits on Mar 30, 2019
-
Improve single vs. multi-touch interaction in dragPan handler, add tests
- Stop an active single-touch drag if the user adds additional fingers and touchZoomRotate is enabled, so the latter can take over interaction - Start a single-touch drag if the user removes all but one finger - Add tests for expected single vs. multi-touch interactions
Anjana Vakil committedMar 30, 2019 Configuration menu - View commit details
-
Copy full SHA for f01f27d - Browse repository at this point
Copy the full SHA f01f27dView commit details
Commits on Aug 27, 2019
-
Update/add drag pan tests (failing) to catch two-finger-pan bug
Additional tests/cases to capture the fact that we only expect touchZoomRotateHandler to take over once we've actually begun zoom/rotate gesture; two-finger straight pan should still be handled by dragPanHandler. See comment on #8100 for more details. Tests currently failing.
Anjana Vakil committedAug 27, 2019 Configuration menu - View commit details
-
Copy full SHA for 7237386 - Browse repository at this point
Copy the full SHA 7237386View commit details -
Defer drag_pan disabling to requestAnimationFrame
Co-authored-by: Anjana Vakil <anjana.vakil@mapbox.com>
Arindam Bose and Anjana Vakil committedAug 27, 2019 Configuration menu - View commit details
-
Copy full SHA for ea0e416 - Browse repository at this point
Copy the full SHA ea0e416View commit details
Commits on Aug 28, 2019
-
Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
Anjana Vakil and Arindam Bose committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 2f2967b - Browse repository at this point
Copy the full SHA 2f2967bView commit details -
Update tests for new drag interaction behavior
Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
Anjana Vakil and Arindam Bose committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 4fb4c6c - Browse repository at this point
Copy the full SHA 4fb4c6cView commit details -
Update handler state on move event, but defer dragstart
To account for the fact that move event handlers might be inspecting the DragPanHandler's (in)active state, update the state in the onMove handler rather than in onDragFrame. However, don't fire the dragstart/movestart events immediately on the move event as we had been doing before; schedule these to be fired on the first drag frame. Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
Anjana Vakil and Arindam Bose committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 2d59350 - Browse repository at this point
Copy the full SHA 2d59350View commit details -
Account for disabling handler on dragstart
Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
Anjana Vakil and Arindam Bose committedAug 28, 2019 Configuration menu - View commit details
-
Copy full SHA for 709d4a3 - Browse repository at this point
Copy the full SHA 709d4a3View commit details
Commits on Aug 30, 2019
-
Don't fire dragend if we never fired dragstart, reset ._shouldStart o…
…n .deactivate()
Anjana Vakil committedAug 30, 2019 Configuration menu - View commit details
-
Copy full SHA for 9643f66 - Browse repository at this point
Copy the full SHA 9643f66View commit details -
Anjana Vakil committed
Aug 30, 2019 Configuration menu - View commit details
-
Copy full SHA for 3fc41d3 - Browse repository at this point
Copy the full SHA 3fc41d3View commit details
Commits on Sep 11, 2019
-
Fix DragPanHandler behavior on touch end/start
Anjana Vakil committedSep 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 7dc031d - Browse repository at this point
Copy the full SHA 7dc031dView commit details -
Anjana Vakil committed
Sep 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 620fe88 - Browse repository at this point
Copy the full SHA 620fe88View commit details
Commits on Sep 13, 2019
-
Anjana Vakil committed
Sep 13, 2019 Configuration menu - View commit details
-
Copy full SHA for 226e17c - Browse repository at this point
Copy the full SHA 226e17cView commit details -
Merge branch 'master' into fix-7196
Anjana Vakil committedSep 13, 2019 Configuration menu - View commit details
-
Copy full SHA for ee3b794 - Browse repository at this point
Copy the full SHA ee3b794View commit details -
Anjana Vakil committed
Sep 13, 2019 Configuration menu - View commit details
-
Copy full SHA for 03cb5db - Browse repository at this point
Copy the full SHA 03cb5dbView commit details
Commits on Sep 18, 2019
-
Replace array loop with .every per reviewer comment
Anjana Vakil committedSep 18, 2019 Configuration menu - View commit details
-
Copy full SHA for b50f108 - Browse repository at this point
Copy the full SHA b50f108View commit details