Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve single vs. multi-touch zoom & pan interaction (#7196) #8100

Merged
merged 16 commits into from
Sep 18, 2019
Merged

Commits on Mar 29, 2019

  1. Pass empty touches list in simulated touchend/touchcancel

    to reflect how we usually expect these events to look
    Anjana Vakil committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    3a8bde2 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. Improve single vs. multi-touch interaction in dragPan handler, add tests

    - Stop an active single-touch drag if the user adds additional fingers
      and touchZoomRotate is enabled, so the latter can take over interaction
    - Start a single-touch drag if the user removes all but one finger
    - Add tests for expected single vs. multi-touch interactions
    Anjana Vakil committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    f01f27d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Update/add drag pan tests (failing) to catch two-finger-pan bug

    Additional tests/cases to capture the fact that we
    only expect touchZoomRotateHandler to take over once
    we've actually begun zoom/rotate gesture; two-finger
    straight pan should still be handled by dragPanHandler.
    
    See comment on #8100 for more details.
    
    Tests currently failing.
    Anjana Vakil committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    7237386 View commit details
    Browse the repository at this point in the history
  2. Defer drag_pan disabling to requestAnimationFrame

    Co-authored-by: Anjana Vakil <anjana.vakil@mapbox.com>
    Arindam Bose and Anjana Vakil committed Aug 27, 2019
    Configuration menu
    Copy the full SHA
    ea0e416 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Consolidate touchend handlers

    Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
    Anjana Vakil and Arindam Bose committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    2f2967b View commit details
    Browse the repository at this point in the history
  2. Update tests for new drag interaction behavior

    Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
    Anjana Vakil and Arindam Bose committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    4fb4c6c View commit details
    Browse the repository at this point in the history
  3. Update handler state on move event, but defer dragstart

    To account for the fact that move event handlers might be
    inspecting the DragPanHandler's (in)active state, update
    the state in the onMove handler rather than in onDragFrame.
    However, don't fire the dragstart/movestart events
    immediately on the move event as we had been doing before;
    schedule these to be fired on the first drag frame.
    
    Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
    Anjana Vakil and Arindam Bose committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    2d59350 View commit details
    Browse the repository at this point in the history
  4. Account for disabling handler on dragstart

    Co-authored-by: Arindam Bose <arindam.bose@mapbox.com>
    Anjana Vakil and Arindam Bose committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    709d4a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2019

  1. Don't fire dragend if we never fired dragstart, reset ._shouldStart o…

    …n .deactivate()
    Anjana Vakil committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    9643f66 View commit details
    Browse the repository at this point in the history
  2. Fix multi-finger no-zoom test

    Anjana Vakil committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    3fc41d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Fix DragPanHandler behavior on touch end/start

    Anjana Vakil committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    7dc031d View commit details
    Browse the repository at this point in the history
  2. Fix lint & flow errors

    Anjana Vakil committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    620fe88 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Fix another flow error

    Anjana Vakil committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    226e17c View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into fix-7196

    Anjana Vakil committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    ee3b794 View commit details
    Browse the repository at this point in the history
  3. Lint & Flow are my BFFs

    Anjana Vakil committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    03cb5db View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Replace array loop with .every per reviewer comment

    Anjana Vakil committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    b50f108 View commit details
    Browse the repository at this point in the history