Fix location dot shadow #8119
Merged
Fix location dot shadow #8119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Apr 4, 2019
|
Looks good to me. Thanks @Bravecow. I think while we're at it, we should make that shadow more visible, because to me 2px, 0.25 opacity is not distinguishable from no shadow. I think at least 8px with 0.5 opacity. What do you think?
|
|
Large shadow makes it more "dirty". I suggest Slightly increasing opacity and 1px more shadow:
|
|
@Bravecow agreed — let's update to this one. |
andrewharvey
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location dot shadow was applied to blue
divwith 2px width. It was covered by 2px width::afterpseudo element.Before:
After: