Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert broken compass touch support; fix flow issues and passive events on iOS #8292

Merged
merged 2 commits into from
May 29, 2019

Conversation

mourner
Copy link
Member

@mourner mourner commented May 29, 2019

#8281 (just merged) accidentally broke passive events on iOS, and also broke Flow tests for the last master commit. The PR should fix both issues. cc @pakastin — note that I use mousePos for touch events too because this function already works with them and should be equivalent.

@mourner
Copy link
Member Author

mourner commented May 29, 2019

I just tested both this PR and master pre-Flow commit and it looks like merged #8226 was broken anyway. :( After dragging the compass, it 1) resets to north after dragging, 2) makes the touch interaction "stuck" afterwards when dragging the map as if one additional finger touches the map.

@mourner mourner force-pushed the fix-flow-passive branch from c0d0759 to 7a75533 Compare May 29, 2019 14:11
@mourner mourner changed the title Fix flow issues and passive events on iOS Fix flow issues and passive events on iOS; revert broken compass touch support May 29, 2019
@mourner mourner changed the title Fix flow issues and passive events on iOS; revert broken compass touch support Revert broken compass touch support; fix flow issues and passive events on iOS May 29, 2019
@mourner mourner merged commit a67c213 into master May 29, 2019
@mourner mourner deleted the fix-flow-passive branch May 29, 2019 14:31
@mourner mourner mentioned this pull request May 29, 2019
@pakastin
Copy link
Contributor

I already fixed those issues in #8291 – just forgot to add the { passive: false }. You can try #8226 + #8291 in https://aviamaps.com/map

@mourner
Copy link
Member Author

mourner commented May 29, 2019

@pakastin my apologies for the mess! Would you mind opening a new PR that combines those on top of master (+ the mousePos change to make Flow happy)?

@pakastin
Copy link
Contributor

Sure yeah, no worries!

@ryanhamley
Copy link
Contributor

Should we take this opportunity to make the compass pitching an optional feature and implement the click reset behavior as per #8208 (comment)?

@pakastin
Copy link
Contributor

Sounds good!

@pakastin
Copy link
Contributor

It's done! #8296

You can try it out here: https://aviamaps.com/map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants