8504 duplicate match exp #8542
Merged
8504 duplicate match exp #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
reviewed
Jul 25, 2019
| return true; | ||
| } | ||
| return false; | ||
| }); |
There was a problem hiding this comment.
Note that this is O(n^2), so might get really slow when the filter has a lot of values (although not sure how likely we are to hit this in practice). An alternative would be to sort the values and then filter linearly, since it doesn't matter what order they are in the match expression:
const uniqueValues = values.sort().filter((v, i) => values[i - 1] !== v);There was a problem hiding this comment.
Nit: you can write this shorter without curly brackets, return and on one line.
asheemmamoowala
approved these changes
Jul 25, 2019
mourner
approved these changes
Jul 25, 2019
| return true; | ||
| } | ||
| return false; | ||
| }); |
There was a problem hiding this comment.
Nit: you can write this shorter without curly brackets, return and on one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8504
The utility to convert legacy filters to expressions currently outputs a
matchexpression as an optimization for certain legacyin, !inoperators. This PR removes duplicate values from the result to ensure that the expression is valid.