Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable text-offset with variable label placement #8642

Merged
merged 8 commits into from
Aug 30, 2019
Merged

Enable text-offset with variable label placement #8642

merged 8 commits into from
Aug 30, 2019

Commits on Aug 29, 2019

  1. Enable text-offset with variable label placement 

    This PR allows using of `text-offset` together with `text-variable-anchor`, if `text-radial-offset` is not provided.
Assuming we got `text-offset` [x, y] the offset is calculated based on the `text-variable-anchor` values as following:

"left": [-x, 0]
"right": [x, 0]
"top": [0, -y]
"bottom": [0, y]
"top-left": [-x, -y]
"top-right": [x, -y]
"bottom-left": [-x, y]
"bottom-right": [x, y]

We allow only positive `text-offset` values for simplicity.
    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    ddc3ad7 View commit details
    Browse the repository at this point in the history

  2. Update specification

    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    59afffb View commit details
    Browse the repository at this point in the history

  3. Enable zero text-radial-offset

    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    d803520 View commit details
    Browse the repository at this point in the history

  4. Update text-radial-offset description 

    Co-Authored-By: Asheem Mamoowala <asheem.mamoowala@mapbox.com>
    @pozdnyakov
    pozdnyakov and Asheem Mamoowala committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    8772e1f View commit details
    Browse the repository at this point in the history

  5. text-offset absolute values are used with variable label placement 

    Also, render tests image size was decreased.
    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    3aa5a22 View commit details
    Browse the repository at this point in the history

  6. Update text-offset description

    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    36f7a13 View commit details
    Browse the repository at this point in the history

  7. radialText... rename

    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    833ccda View commit details
    Browse the repository at this point in the history

  8. Introduce INVALID_TEXT_OFFSET

    @pozdnyakov
    pozdnyakov committed Aug 29, 2019
    Configuration menu
    Copy the full SHA
    36dbda2 View commit details
    Browse the repository at this point in the history