-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icon/text collisionBox translation #8659
Conversation
@zmiao It looks safe to update the fixture for that test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! One small thing: there are some extra spaces added to some lines that didn't otherwise change. If possible it might be good to not include these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ansis the whitespace changes pass the linter, so maybe the eslint rules need to be updated to enforce a consistent convention here. That can be handled separately IMO
@ansis Whitespace is moved + changelog is added. Thanks for heads up. |
* init fix * fix lint error * fix indentation and wrong variable * add line placement translate render test * revert accidently added blank line * update comments * update one test fixture * Add changelog + remove whitespace
Fix: js part of mapbox/mapbox-gl-native#13526
The root cause for it is that when rendering the symbols, the translate offset is only applied to icon/text, but the corresponding
collisionBox
is ignored. AlsocollisionBox
in currentSymbolBucket
needs to be split for icon and text symbol separately, in case they have different translate parameter.Launch Checklist