Fix icon/text collisionBox translation #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change leads to one failing render test: debug/collision. As the rendering order may be changed for icon and text collisionBox, as they are now separated. Results are depicted as following: actual: diff: |
|
@zmiao It looks safe to update the fixture for that test. |
ansis
reviewed
Aug 27, 2019
asheemmamoowala
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
👍
@ansis the whitespace changes pass the linter, so maybe the eslint rules need to be updated to enforce a consistent convention here. That can be handled separately IMO
|
@ansis Whitespace is moved + changelog is added. Thanks for heads up. |
stepankuzmin
pushed a commit
to stepankuzmin/mapbox-gl-js
that referenced
this pull request
Sep 9, 2019
* init fix * fix lint error * fix indentation and wrong variable * add line placement translate render test * revert accidently added blank line * update comments * update one test fixture * Add changelog + remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: js part of mapbox/mapbox-gl-native#13526
The root cause for it is that when rendering the symbols, the translate offset is only applied to icon/text, but the corresponding
collisionBoxis ignored. AlsocollisionBoxin currentSymbolBucketneeds to be split for icon and text symbol separately, in case they have different translate parameter.Launch Checklist