Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add call to update and check before classList #8757

Merged
merged 1 commit into from
Sep 17, 2019
Merged

add call to update and check before classList #8757

merged 1 commit into from
Sep 17, 2019

Conversation

zxwandrew
Copy link
Contributor

@zxwandrew zxwandrew commented Sep 15, 2019 •
edited by andrewharvey
Loading

  • [ X ] briefly describe the changes in this PR
    • fixes Fix Popup.trackPointer Cannot read property 'classList' of undefined errors #8669
    • Add a call to _update when calling trackPointer. Checks to see if this._container exists. If not make sure tracking is set appropriately afterwards in _update. Also make sure the .mapboxgl-popup-track-pointer class is being properly applied in all scenarios. Added some unit test to ensure some new cases will now work.
  • [ X ] write tests for all new functionality
  • [ X ] manually test the debug page

andrewharvey
andrewharvey approved these changes Sep 17, 2019
View reviewed changes
Copy link
Collaborator

@andrewharvey andrewharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you! I also tested this and found it worked well.

asheemmamoowala
asheemmamoowala approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you and congratulations on your first contribution @zxwandrew!

@asheemmamoowala asheemmamoowala merged commit 102ec0c into mapbox:master Sep 17, 2019
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewharvey andrewharvey andrewharvey approved these changes

@asheemmamoowala asheemmamoowala asheemmamoowala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Popup.trackPointer Cannot read property 'classList' of undefined errors
3 participants
@zxwandrew @andrewharvey @asheemmamoowala