Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update style spec with ResolvedImage type #8841

Closed
wants to merge 1 commit into from
Closed

Update style spec with ResolvedImage type #8841

wants to merge 1 commit into from

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

There was a mismatch in the documentation after we updated the type name to ResolvedImage. This also turns out to be causing issues with coercing a string to ResolvedImage so this fixes #8831

  • briefly describe the changes in this PR
  • document any changes to public APIs
  • manually test the debug page

@ryanhamley ryanhamley mentioned this pull request Oct 8, 2019
Merged
2 tasks
@chloekraw chloekraw added this to the release-sangria milestone Oct 22, 2019
@ryanhamley ryanhamley mentioned this pull request Oct 25, 2019
Merged
3 tasks
@ryanhamley
Copy link
Contributor Author

ryanhamley commented Oct 25, 2019 •
edited
Loading

Close in favor of #8901

@ryanhamley ryanhamley closed this Oct 25, 2019
@ryanhamley ryanhamley deleted the update-style-spec branch October 25, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanhamley ryanhamley

Labels
None yet
Projects
None yet
Milestone
release-sangria
Development

Successfully merging this pull request may close these issues.

styleimagemissing emitted while Image operator deems the image available
2 participants
@ryanhamley @chloekraw