Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageBitmap and OffscreenCanvas for DEM tiles #8845
ImageBitmap and OffscreenCanvas for DEM tiles #8845
Changes from 15 commits
33942bb
58756d7
4c8bae2
0509d5c
1fdf49e
5ad0c74
5089802
8568876
89e33da
4664f65
84119b9
84b6983
453389e
19f4ab7
6d42581
199c2d8
91789df
d8bc399
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
===
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional as a
null or undefined
checkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then let's use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then that would run when
supportsOffscreenCanvas
isfalse
as well. I was intending this to be lazy and cached.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what situations would
supportsOffscreenCanvas
beundefined
then? Let's add some flowtype to the variable to make it clearer what states it can be in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really wound't ever be
undefined
I was just sticking to the most easiestmaybe type
refinement implementation for flow( I guess i still forgot the annotation 🤦♂ ) https://flow.org/en/docs/types/maybe/#toc-refining-maybe-types (the 2nd example)I added the
?boolean
annotation and got rid of the initialnull
assignment so its more inline with flow maybe types.