Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to load rtl-text-plugin lazily #8865

Merged
merged 14 commits into from
Oct 24, 2019
Merged

Add option to load rtl-text-plugin lazily #8865

merged 14 commits into from
Oct 24, 2019

Commits on Oct 12, 2019

  1. Autoload rtlTextPlugin using rtlTextPluginURL map option

    Arindam Bose committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    f285c5f View commit details
    Browse the repository at this point in the history

  2. fix flow errors

    Arindam Bose committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    7b55f59 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Skip rendering rtl text if plugin is not loaded

    Arindam Bose committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    ad15029 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:mapbox/mapbox-gl-js into rtl-requ… 

    …ired-plugin

# Conflicts:
#	src/source/rtl_text_plugin.js
    Arindam Bose committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    5bb6ff6 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. diferred laoding of plugin while not rendering text

    Arindam Bose committed Oct 16, 2019
    1 Configuration menu
    Copy the full SHA
    51158d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Rearchitected rtlTextPlugin -> worker messaging. 

    - main thread now pings workers with an `pluginStateChange` event that syncs the state of the plugin on the main thread with the worker
- worker logic is now reactive to this state change, and will load and parse the plugin on appropriate state change
    Arindam Bose committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    8e03389 View commit details
    Browse the repository at this point in the history

  2. Fix lint issue

    Arindam Bose committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    4fd3a66 View commit details
    Browse the repository at this point in the history

  3. Remove rtlTextPlugin Map option

    Arindam Bose committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    c3688f6 View commit details
    Browse the repository at this point in the history

  4. fancier rtl-text plugin demo page

    Arindam Bose committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    ffe7dea View commit details
    Browse the repository at this point in the history

  5. Lint

    Arindam Bose committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    05db065 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Apply comments change suggestions from code review 

    Co-Authored-By: Asheem Mamoowala <asheem.mamoowala@mapbox.com>
    Arindam Bose and Asheem Mamoowala authored Oct 23, 2019
    Configuration menu
    Copy the full SHA
    89b3bcb View commit details
    Browse the repository at this point in the history

  2. Switch to assert instead of throwing error

    Arindam Bose committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    247226e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Remove webkitURL and switch to using deferred

    Arindam Bose committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    edc94ad View commit details
    Browse the repository at this point in the history

  2. Fix unit test

    Arindam Bose committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    767c9dd View commit details
    Browse the repository at this point in the history