-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix DragRotate when mouseup occurs outside window or iframe #9512
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import {test} from '../../../util/test'; | ||
| import {extend} from '../../../../src/util/util'; | ||
| import window from '../../../../src/util/window'; | ||
| import Map from '../../../../src/ui/map'; | ||
| import DOM from '../../../../src/util/dom'; | ||
| import simulate from '../../../util/simulate_interaction'; | ||
| import browser from '../../../../src/util/browser'; | ||
|
|
||
| function createMap(t, options) { | ||
| t.stub(Map.prototype, '_detectMissingCSS'); | ||
| return new Map(extend({container: DOM.create('div', '', window.document.body)}, options)); | ||
| } | ||
|
|
||
| test('MouseRotateHandler#isActive', (t) => { | ||
| const map = createMap(t); | ||
| const mouseRotate = map.handlers._handlersById.mouseRotate; | ||
|
|
||
| // Prevent inertial rotation. | ||
| t.stub(browser, 'now').returns(0); | ||
| t.equal(mouseRotate.isActive(), false); | ||
|
|
||
| simulate.mousedown(map.getCanvas(), {buttons: 2, button: 2}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), false); | ||
|
|
||
| simulate.mousemove(map.getCanvas(), {buttons: 2, clientX: 10, clientY: 10}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), true); | ||
|
|
||
| simulate.mouseup(map.getCanvas(), {buttons: 0, button: 2}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), false); | ||
|
|
||
| map.remove(); | ||
| t.end(); | ||
| }); | ||
|
|
||
| test('MouseRotateHandler#isActive #4622 regression test', (t) => { | ||
| const map = createMap(t); | ||
| const mouseRotate = map.handlers._handlersById.mouseRotate; | ||
|
|
||
| // Prevent inertial rotation. | ||
| simulate.mousedown(map.getCanvas(), {buttons: 2, button: 2}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), false); | ||
|
|
||
| simulate.mousemove(map.getCanvas(), {buttons: 2, clientX: 10, clientY: 10}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), true); | ||
|
|
||
| // Some browsers don't fire mouseup when it happens outside the window. | ||
| // Make the handler in active when it encounters a mousemove without the button pressed. | ||
|
|
||
| simulate.mousemove(map.getCanvas(), {buttons: 0, clientX: 10, clientY: 10}); | ||
| map._renderTaskQueue.run(); | ||
| t.equal(mouseRotate.isActive(), false); | ||
|
|
||
| map.remove(); | ||
| t.end(); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to press the left button, move the mouse outside the window, release the button, then click the left button again and bring it back inside the window so that this isn't triggered? Or does releasing the button always make
e.buttonsundefined?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.buttonsgot added in safari in 11. To handle those browsers more gracefully it's saying "yes the button is pressed" in those cases even if we can't tell. If this bug were present in those browsers it would remain but everything else would still work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And as you noted it's not present in android chrome at all. This would handle that gracefully if you had a mouse connected to Android.