Simplified Chinese #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmartinelli
approved these changes
Jul 4, 2018
|
Hmm. Although the |
|
The documentation is a little confusing, but |
Closed
|
I'm closing this since #39 added support for Simplified and Traditional Chinese while dropping v7 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Simplified Chinese, falling back on Chinese for certain low-zoom-level source layers that lack Simplified Chinese data in Streets source v7.
locale-utils has been added as a dependency. This library is used for locale code matching in various other Mapbox tools, so using it here ensures consistent behavior. As this is the library’s first dependency, its inclusion breaks the normal
<script>tag usage that the examples rely on. A build step will need to be added to build a version of the library that the examples can include direclty.Additionally, a special case may need to be added for
mul, as described in #17 (comment). locale-utils only supports valid IETF language tags, so supporting that PR’slocalcode would be less straightforward.Fixes #5.
/cc @lukasmartinelli @bsudekum @chriswu42