This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
[macos] respect MGLMapSnapshotter on macOS. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because this is a PR from a fork, we'll need to jump through a few hoops to get it merged. |
|
Thanks, @julianrex. Should externals create pull requests in another way to reduce the "hoops"? |
|
It's no problem - we can take it over the finish line. |
Closed
|
CI triggered by #465 |
katydecorah
pushed a commit
that referenced
this pull request
Sep 30, 2020
* master: Made changes to podspec for Xcode 12 build issues (#482) Fix frame-delay bug affect UIViews. (#483) Bump sdk version to 6.2.1 (#477) Update gl-native to 5.1.0 (#475) Fix crash with nil font family name (#476) Location manager crash fix when a selector is not implemented (#474) Address crash when localFontFamilyName is nil (#467) Ensure pending completion blocks, even if rendering is not strictly required. (#463) [macos] respect MGLMapSnapshotter on macOS. (#448) Support Xcode 12 by excluding arm64 simulators and bumping Telemetry to 0.10.4 (#458) Release prep for version 6.2.0 (#453) Rename identifer -> identifier (#423) Fixed some typos and updated change log (#443)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>MGLMapSnapshotOptionsto respectshowsLogo. ([#335](https://github.com/mapbox/mapbox-gl-native-ios/issues/335))</changelog>#159 made it possible to set
showsLogo = falseon the snapshotter on iOS (when not using any mapbox services). As stated in #335, this did not work on macOS. This pull request fixes this on macOS as well.