This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Switch to KVO for configuration values #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianrex
suggested changes
Dec 11, 2019
platform/ios/src/MGLMapboxEvents.m
Outdated
Comment on lines
105
to
106
| @catch (NSException *exception) {} //Purposefully unhandled. This should only fail if we are unable to add an observer in the first place. | ||
| } |
There was a problem hiding this comment.
Why does/can this happen?
There was a problem hiding this comment.
It's unlikely. But if, for example, another class were to observe this same parameter and removed the observer and then we tried to remove the same observer a second time in this class then it could cause a crash. Since we're setting this at init and only use these keys within this class; I don't think it should happen but I just wanted to add it as a precaution (even if it is an unnecessary one).
There was a problem hiding this comment.
Previous code comment probably wouldn't happen. I cleaned the comment up with the more realistic scenario as well.
Also cleans up comment
julianrex
approved these changes
Dec 11, 2019
alfwatt
reviewed
Dec 11, 2019
alfwatt
approved these changes
Dec 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce the amount of callbacks we get from NSUserDefaults changes.