Fix within expression serialization + fix within expression equal ope…

…rator
mapbox · Mar 4, 2020 · 277199e · 277199e
1 parent 3c499cd
commit 277199e
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/mbgl/style/expression/within.cpp b/src/mbgl/style/expression/within.cpp
@@ -233,6 +233,13 @@ Value valueConverter(const mapbox::geojson::rapidjson_value& v) {
         }
         return result;
     }
+    if (v.IsObject()) {
+        std::unordered_map<std::string, Value> result;
+        for (const auto& m : v.GetObject()) {
+            result.emplace(m.name.GetString(), valueConverter(m.value));
+        }
+        return result;
+    }
     // Ignore other types as valid geojson only contains above types.
     return Null;
 }
@@ -255,7 +262,7 @@ mbgl::Value Within::serialize() const {
 bool Within::operator==(const Expression& e) const {
     if (e.getKind() == Kind::Within) {
         auto rhs = static_cast<const Within*>(&e);
-        return geoJSONSource == rhs->geoJSONSource;
+        return geoJSONSource == rhs->geoJSONSource && geometries == rhs->geometries && polygonBBox == rhs->polygonBBox;
     }
     return false;
 }