[android] - correctly convert Android int colors with to-color expres…

…sion
mapbox · Mar 23, 2018 · 295f345 · 295f345
1 parent 61e6e62
commit 295f345
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 38 deletions.
diff --git a/...d/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/expressions/Expression.java b/...d/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/style/expressions/Expression.java
@@ -135,7 +135,7 @@ public static Expression literal(@NonNull Object[] array) {
    * @return the color expression
    */
   public static Expression color(@ColorInt int color) {
-    return new ExpressionLiteral(new Color(color));
+    return toColor(literal(PropertyFactory.colorToRgbaString(color)));
   }
 
   /**
@@ -1735,9 +1735,7 @@ public Object[] toArray() {
    */
   private Object toValue(ExpressionLiteral expressionValue) {
     Object value = expressionValue.toValue();
-    if (value instanceof Expression.Color) {
-      return ((Expression.Color) value).convertColor();
-    } else if (value instanceof Expression.ExpressionLiteral) {
+    if (value instanceof Expression.ExpressionLiteral) {
       return toValue((ExpressionLiteral) value);
     } else if (value instanceof Expression) {
       return ((Expression) value).toArray();
@@ -1893,32 +1891,6 @@ public static class Interpolator extends Expression {
     }
   }
 
-  /**
-   * Expression color type.
-   */
-  public static class Color {
-
-    private int color;
-
-    /**
-     * Creates a color color type from a color int.
-     *
-     * @param color the int color
-     */
-    public Color(@ColorInt int color) {
-      this.color = color;
-    }
-
-    /**
-     * Converts the int color to rgba(d, d, d, d) string representation
-     *
-     * @return the string representation of a color
-     */
-    String convertColor() {
-      return PropertyFactory.colorToRgbaString(color);
-    }
-  }
-
   /**
    * Expression array type.
    */

diff --git a/...pboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/style/expressions/ExpressionTest.java b/...pboxGLAndroidSDK/src/test/java/com/mapbox/mapboxsdk/style/expressions/ExpressionTest.java
@@ -2,8 +2,6 @@
 
 import android.graphics.Color;
 
-import com.mapbox.mapboxsdk.style.layers.PropertyFactory;
-
 import org.junit.Test;
 
 import java.util.Arrays;
@@ -113,7 +111,7 @@ public void testRgbaLiteral() throws Exception {
 
   @Test
   public void testToRgba() throws Exception {
-    Object[] expected = new Object[] {"to-rgba", PropertyFactory.colorToRgbaString(Color.RED)};
+    Object[] expected = new Object[] {"to-rgba", new Object[] {"to-color", "rgba(255, 0, 0, 255)"}};
     Object[] actual = toRgba(color(Color.RED)).toArray();
     assertTrue("expression should match", Arrays.deepEquals(expected, actual));
   }
@@ -1087,6 +1085,14 @@ public void testLiteralPrimitiveArrayConversion() throws Exception {
     float[] array = new float[] {0.2f, 0.5f};
     Object[] expected = new Object[] {"literal", new Object[] {0.2f, 0.5f}};
     Object[] actual = literal(array).toArray();
-    assertEquals("primitive array should be convered", expected, actual);
+    assertEquals("primitive array should be converted", expected, actual);
   }
+
+  @Test
+  public void testColorConversion() {
+    Expression greenColor = color(0xFF00FF00);
+    Object[] expected = new Object[] {"to-color", "rgba(0, 255, 0, 255)"};
+    assertTrue("expression should match", Arrays.deepEquals(expected, greenColor.toArray()));
+  }
+
 }
diff --git a/...pp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/DataDrivenStyleActivity.java b/...pp/src/main/java/com/mapbox/mapboxsdk/testapp/activity/style/DataDrivenStyleActivity.java
@@ -1,5 +1,6 @@
 package com.mapbox.mapboxsdk.testapp.activity.style;
 
+import android.graphics.Color;
 import android.os.Bundle;
 import android.support.v7.app.AppCompatActivity;
 import android.view.Menu;
@@ -33,6 +34,7 @@
 import static com.mapbox.mapboxsdk.style.expressions.Expression.step;
 import static com.mapbox.mapboxsdk.style.expressions.Expression.stop;
 import static com.mapbox.mapboxsdk.style.expressions.Expression.zoom;
+import static com.mapbox.mapboxsdk.style.expressions.Expression.color;
 import static com.mapbox.mapboxsdk.style.layers.PropertyFactory.fillAntialias;
 import static com.mapbox.mapboxsdk.style.layers.PropertyFactory.fillColor;
 import static com.mapbox.mapboxsdk.style.layers.PropertyFactory.fillOpacity;
@@ -173,9 +175,9 @@ private void addExponentialZoomFunction() {
       fillColor(
         interpolate(
           exponential(0.5f), zoom(),
-          stop(1, rgb(255, 0, 0)),
-          stop(5, rgb(0, 0, 255)),
-          stop(10, rgb(0, 255, 0))
+          stop(1, color(Color.RED)),
+          stop(5, color(Color.BLUE)),
+          stop(10, color(Color.GREEN))
         )
       )
     );
@@ -460,7 +462,7 @@ private void addParksLayer() {
     // Add a fill layer
     mapboxMap.addLayer(new FillLayer(AMSTERDAM_PARKS_LAYER, source.getId())
       .withProperties(
-        fillColor(rgba(0.0f, 0.0f, 0.0f, 0.5f)),
+        fillColor(color(Color.GREEN)),
         fillOutlineColor(rgb(0, 0, 255)),
         fillAntialias(true)
       )