[core] Avoid wrapping longitude values of exactly 180 and 360 (#12797) (

#13006)
mapbox · Oct 25, 2018 · 3ec0231 · 3ec0231
1 parent 7def088
commit 3ec0231
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/include/mbgl/util/geo.hpp b/include/mbgl/util/geo.hpp
@@ -61,7 +61,7 @@ class LatLng {
     // world, unwrap the start longitude to ensure the shortest path is taken.
     void unwrapForShortestPath(const LatLng& end) {
         const double delta = std::abs(end.lon - lon);
-        if (delta < util::LONGITUDE_MAX || delta > util::DEGREES_MAX) return;
+        if (delta <= util::LONGITUDE_MAX || delta >= util::DEGREES_MAX) return;
         if (lon > 0 && end.lon < 0) lon -= util::DEGREES_MAX;
         else if (lon < 0 && end.lon > 0) lon += util::DEGREES_MAX;
     }

diff --git a/scripts/changelog_staging/invalid-latlngbounds.json b/scripts/changelog_staging/invalid-latlngbounds.json
@@ -0,0 +1,4 @@
+{
+    "core": "When using longitude values of +-180° in LatLngBounds, the longitude was being improperly wrapped resulting in an unexpected bounding box.",
+    "issue": 12797
+}