Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Commit

Permalink
Bump mason
Browse files Browse the repository at this point in the history 
Fixes aarch64 build for android.

Fixes #1956
Fixes #3128
  • Loading branch information
@tmpsantos
tmpsantos committed Mar 17, 2016
1 parent 6cb606b commit 51a3907
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .mason
Submodule .mason updated 1 files
+3 −1 mason.sh

2 comments on commit 51a3907

@mb12
Copy link

@mb12 mb12 commented on 51a3907 Mar 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmpsantos Thanks for fixing this bug. Can you please kindly clarify the following?

  1. Were any dependencies (libuv etc.) also recompiled for this?
  2. arm-v7 is still using gold. Is that intentional?

@tmpsantos
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were any dependencies (libuv etc.) also recompiled for this?

If you are asking if the deps were compiled to ARMv8 the answer is yes. If they were compiled and linked using bfd instead of gold the answer is "I don't know what linker was used for the deps". I kept using the same binaries we had before.

arm-v7 is still using gold. Is that intentional?

Yes, arm-v7 and everything else but arm-v8. We have been using gold for a while and we are close to a release and I didn't want to change that.

I filed a bug on AOP to see if I can get more answers why gold seems broken for ARMv8:
https://code.google.com/p/android/issues/detail?id=204151

Please sign in to comment.