[android] - hold off handling hover events untill map has been created

mapbox · Oct 10, 2017 · 7722cdf · 7722cdf
1 parent 24bd336
commit 7722cdf
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapView.java
@@ -2,8 +2,8 @@
 
 import android.content.Context;
 import android.graphics.PointF;
-import android.os.Build;
 import android.opengl.GLSurfaceView;
+import android.os.Build;
 import android.os.Bundle;
 import android.support.annotation.CallSuper;
 import android.support.annotation.IntDef;
@@ -47,9 +47,9 @@
 
 import timber.log.Timber;
 
+import static android.opengl.GLSurfaceView.RENDERMODE_WHEN_DIRTY;
 import static com.mapbox.mapboxsdk.maps.widgets.CompassView.TIME_MAP_NORTH_ANIMATION;
 import static com.mapbox.mapboxsdk.maps.widgets.CompassView.TIME_WAIT_IDLE;
-import static android.opengl.GLSurfaceView.RENDERMODE_WHEN_DIRTY;
 
 /**
  * <p>
@@ -382,7 +382,7 @@ public void onDestroy() {
 
   @Override
   public boolean onTouchEvent(MotionEvent event) {
-    if (!isMapInitialized()) {
+    if (!isMapInitialized() || !isZoomButtonControllerInitialized()) {
       return super.onTouchEvent(event);
     }
 
@@ -419,6 +419,10 @@ public boolean onGenericMotionEvent(MotionEvent event) {
 
   @Override
   public boolean onHoverEvent(MotionEvent event) {
+    if (!isZoomButtonControllerInitialized()) {
+      return super.onHoverEvent(event);
+    }
+
     switch (event.getActionMasked()) {
       case MotionEvent.ACTION_HOVER_ENTER:
       case MotionEvent.ACTION_HOVER_MOVE:
@@ -506,7 +510,9 @@ protected void onSizeChanged(int width, int height, int oldw, int oldh) {
   @CallSuper
   protected void onDetachedFromWindow() {
     super.onDetachedFromWindow();
-    mapZoomButtonController.setVisible(false);
+    if (isZoomButtonControllerInitialized()) {
+      mapZoomButtonController.setVisible(false);
+    }
   }
 
   // Called when view is hidden and shown
@@ -516,7 +522,7 @@ protected void onVisibilityChanged(@NonNull View changedView, int visibility) {
       return;
     }
 
-    if (mapZoomButtonController != null) {
+    if (isZoomButtonControllerInitialized()) {
       mapZoomButtonController.setVisible(visibility == View.VISIBLE);
     }
   }
@@ -582,6 +588,10 @@ private boolean isMapInitialized() {
     return nativeMapView != null;
   }
 
+  private boolean isZoomButtonControllerInitialized() {
+    return mapZoomButtonController != null;
+  }
+
   MapboxMap getMapboxMap() {
     return mapboxMap;
   }