Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Commit

Permalink
[core] Remove unused RenderLayer::clone
Browse files Browse the repository at this point in the history
  • Loading branch information
jfirebaugh committed May 11, 2017
1 parent 64e0910 commit 7b2e722
Show file tree
Hide file tree
Showing 17 changed files with 0 additions and 51 deletions.
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_background_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ const style::BackgroundLayer::Impl& RenderBackgroundLayer::impl() const {
return static_cast<const style::BackgroundLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderBackgroundLayer::clone() const {
return std::make_unique<RenderBackgroundLayer>(*this);
}

std::unique_ptr<Bucket> RenderBackgroundLayer::createBucket(const BucketParameters &,
const std::vector<const RenderLayer *> &) const {
assert(false);
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_background_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderBackgroundLayer: public RenderLayer {
RenderBackgroundLayer(Immutable<style::BackgroundLayer::Impl>);
~RenderBackgroundLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_circle_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ const style::CircleLayer::Impl& RenderCircleLayer::impl() const {
return static_cast<const style::CircleLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderCircleLayer::clone() const {
return std::make_unique<RenderCircleLayer>(*this);
}

std::unique_ptr<Bucket> RenderCircleLayer::createBucket(const BucketParameters& parameters, const std::vector<const RenderLayer*>& layers) const {
return std::make_unique<CircleBucket>(parameters, layers);
}
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_circle_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderCircleLayer: public RenderLayer {
RenderCircleLayer(Immutable<style::CircleLayer::Impl>);
~RenderCircleLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_custom_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ const style::CustomLayer::Impl& RenderCustomLayer::impl() const {
return static_cast<const style::CustomLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderCustomLayer::clone() const {
return std::make_unique<RenderCustomLayer>(*this);
}

void RenderCustomLayer::evaluate(const PropertyEvaluationParameters&) {
passes = RenderPass::Translucent;
}
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_custom_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ class RenderCustomLayer: public RenderLayer {
RenderCustomLayer(Immutable<style::CustomLayer::Impl>);
~RenderCustomLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) final {}
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_fill_extrusion_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ const style::FillExtrusionLayer::Impl& RenderFillExtrusionLayer::impl() const {
return static_cast<const style::FillExtrusionLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderFillExtrusionLayer::clone() const {
return std::make_unique<RenderFillExtrusionLayer>(*this);
}

std::unique_ptr<Bucket> RenderFillExtrusionLayer::createBucket(const BucketParameters& parameters, const std::vector<const RenderLayer*>& layers) const {
return std::make_unique<FillExtrusionBucket>(parameters, layers);
}
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_fill_extrusion_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderFillExtrusionLayer: public RenderLayer {
RenderFillExtrusionLayer(Immutable<style::FillExtrusionLayer::Impl>);
~RenderFillExtrusionLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_fill_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ const style::FillLayer::Impl& RenderFillLayer::impl() const {
return static_cast<const style::FillLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderFillLayer::clone() const {
return std::make_unique<RenderFillLayer>(*this);
}

std::unique_ptr<Bucket> RenderFillLayer::createBucket(const BucketParameters& parameters, const std::vector<const RenderLayer*>& layers) const {
return std::make_unique<FillBucket>(parameters, layers);
}
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_fill_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderFillLayer: public RenderLayer {
RenderFillLayer(Immutable<style::FillLayer::Impl>);
~RenderFillLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
3 changes: 0 additions & 3 deletions src/mbgl/renderer/render_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ class RenderLayer {
public:
virtual ~RenderLayer() = default;

// Create an identical copy of this layer.
virtual std::unique_ptr<RenderLayer> clone() const = 0;

// Partially evaluate paint properties based on a set of classes.
virtual void cascade(const CascadeParameters&) = 0;

Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_line_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ const style::LineLayer::Impl& RenderLineLayer::impl() const {
return static_cast<const style::LineLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderLineLayer::clone() const {
return std::make_unique<RenderLineLayer>(*this);
}

std::unique_ptr<Bucket> RenderLineLayer::createBucket(const BucketParameters& parameters, const std::vector<const RenderLayer*>& layers) const {
return std::make_unique<LineBucket>(parameters, layers, impl().layout);
}
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_line_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderLineLayer: public RenderLayer {
RenderLineLayer(Immutable<style::LineLayer::Impl>);
~RenderLineLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_raster_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ const style::RasterLayer::Impl& RenderRasterLayer::impl() const {
return static_cast<const style::RasterLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderRasterLayer::clone() const {
return std::make_unique<RenderRasterLayer>(*this);
}

std::unique_ptr<Bucket> RenderRasterLayer::createBucket(const BucketParameters&, const std::vector<const RenderLayer*>&) const {
assert(false);
return nullptr;
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_raster_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ class RenderRasterLayer: public RenderLayer {
RenderRasterLayer(Immutable<style::RasterLayer::Impl>);
~RenderRasterLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down
4 changes: 0 additions & 4 deletions src/mbgl/renderer/render_symbol_layer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ const style::SymbolLayer::Impl& RenderSymbolLayer::impl() const {
return static_cast<const style::SymbolLayer::Impl&>(*baseImpl);
}

std::unique_ptr<RenderLayer> RenderSymbolLayer::clone() const {
return std::make_unique<RenderSymbolLayer>(*this);
}

std::unique_ptr<Bucket> RenderSymbolLayer::createBucket(const BucketParameters&, const std::vector<const RenderLayer*>&) const {
assert(false); // Should be calling createLayout() instead.
return nullptr;
Expand Down
2 changes: 0 additions & 2 deletions src/mbgl/renderer/render_symbol_layer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ class RenderSymbolLayer: public RenderLayer {
RenderSymbolLayer(Immutable<style::SymbolLayer::Impl>);
~RenderSymbolLayer() final = default;

std::unique_ptr<RenderLayer> clone() const override;

void cascade(const CascadeParameters&) override;
void evaluate(const PropertyEvaluationParameters&) override;
bool hasTransition() const override;
Expand Down

0 comments on commit 7b2e722

Please sign in to comment.