[android] - execute notifying listeners when not idle

mapbox · Oct 18, 2017 · a221b45 · a221b45
1 parent fe6e0c3
commit a221b45
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/...id/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/CameraChangeDispatcher.java b/...id/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/CameraChangeDispatcher.java
@@ -25,18 +25,22 @@ class CameraChangeDispatcher implements MapboxMap.OnCameraMoveStartedListener, M
   private OnCameraMoveListener onCameraMoveListener;
   private OnCameraIdleListener onCameraIdleListener;
 
+  @Deprecated
   void setOnCameraMoveStartedListener(OnCameraMoveStartedListener onCameraMoveStartedListener) {
     this.onCameraMoveStartedListener = onCameraMoveStartedListener;
   }
 
+  @Deprecated
   void setOnCameraMoveCanceledListener(OnCameraMoveCanceledListener onCameraMoveCanceledListener) {
     this.onCameraMoveCanceledListener = onCameraMoveCanceledListener;
   }
 
+  @Deprecated
   void setOnCameraMoveListener(OnCameraMoveListener onCameraMoveListener) {
     this.onCameraMoveListener = onCameraMoveListener;
   }
 
+  @Deprecated
   void setOnCameraIdleListener(OnCameraIdleListener onCameraIdleListener) {
     this.onCameraIdleListener = onCameraIdleListener;
   }
@@ -46,12 +50,14 @@ public void onCameraMoveStarted(int reason) {
     if (!idle) {
       return;
     }
-
     idle = false;
+
+    // deprecated API
     if (onCameraMoveStartedListener != null) {
       onCameraMoveStartedListener.onCameraMoveStarted(reason);
     }
 
+    // new API
     if (!onCameraMoveStartedListenerList.isEmpty()) {
       for (OnCameraMoveStartedListener cameraMoveStartedListener : onCameraMoveStartedListenerList) {
         cameraMoveStartedListener.onCameraMoveStarted(reason);
@@ -61,11 +67,13 @@ public void onCameraMoveStarted(int reason) {
 
   @Override
   public void onCameraMove() {
+    // deprecated API
     if (onCameraMoveListener != null && !idle) {
       onCameraMoveListener.onCameraMove();
     }
 
-    if (!onCameraMoveListenerList.isEmpty()) {
+    // new API
+    if (!onCameraMoveListenerList.isEmpty() && !idle) {
       for (OnCameraMoveListener cameraMoveListener : onCameraMoveListenerList) {
         cameraMoveListener.onCameraMove();
       }
@@ -74,11 +82,13 @@ public void onCameraMove() {
 
   @Override
   public void onCameraMoveCanceled() {
+    // deprecated API
     if (onCameraMoveCanceledListener != null && !idle) {
       onCameraMoveCanceledListener.onCameraMoveCanceled();
     }
 
-    if (!onCameraMoveCanceledListenerList.isEmpty()) {
+    // new API
+    if (!onCameraMoveCanceledListenerList.isEmpty() && !idle) {
       for (OnCameraMoveCanceledListener cameraMoveCanceledListener : onCameraMoveCanceledListenerList) {
         cameraMoveCanceledListener.onCameraMoveCanceled();
       }
@@ -89,10 +99,12 @@ public void onCameraMoveCanceled() {
   public void onCameraIdle() {
     if (!idle) {
       idle = true;
+      // deprecated API
       if (onCameraIdleListener != null) {
         onCameraIdleListener.onCameraIdle();
       }
 
+      // new API
       if (!onCameraIdleListenerList.isEmpty()) {
         for (OnCameraIdleListener cameraIdleListener : onCameraIdleListenerList) {
           cameraIdleListener.onCameraIdle();