[android] - checking is renderer is not destroyed before delivering t…

…he snapshot
mapbox · May 2, 2018 · cf4b4e7 · cf4b4e7
1 parent a6d70c2
commit cf4b4e7
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 27 deletions.
diff --git a/...roid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/MapRenderer.java b/...roid/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/renderer/MapRenderer.java
@@ -37,11 +37,11 @@ public void onStart() {
   }
 
   public void onPause() {
-    nativeOnPause();
+    // Implement if needed
   }
 
   public void onResume() {
-    nativeOnResume();
+    // Implement if needed
   }
 
   public void onStop() {
@@ -124,10 +124,6 @@ private native void nativeInitialize(MapRenderer self,
 
   private native void nativeRender();
 
-  private native void nativeOnResume();
-
-  private native void nativeOnPause();
-
   private long frames;
   private long timeElapsed;
 

diff --git a/platform/android/src/map_renderer.cpp b/platform/android/src/map_renderer.cpp
@@ -29,6 +29,7 @@ MapRenderer::MapRenderer(jni::JNIEnv& _env, jni::Object<MapRenderer> obj,
 MapRenderer::~MapRenderer() = default;
 
 void MapRenderer::reset() {
+    destroyed = true;
     // Make sure to destroy the renderer on the GL Thread
     auto self = ActorRef<MapRenderer>(*this, mailbox);
     self.ask(&MapRenderer::resetRenderer).wait();
@@ -88,8 +89,10 @@ void MapRenderer::requestSnapshot(SnapshotCallback callback) {
     self.invoke(
             &MapRenderer::scheduleSnapshot,
             std::make_unique<SnapshotCallback>([&, callback=std::move(callback), runloop=util::RunLoop::Get()](PremultipliedImage image) {
-                runloop->invoke([callback=std::move(callback), image=std::move(image)]() mutable {
-                    callback(std::move(image));
+                runloop->invoke([callback=std::move(callback), image=std::move(image), renderer=std::move(this)]() mutable {
+                    if (renderer && !renderer->destroyed) {
+                        callback(std::move(image));
+                    }
                 });
                 snapshotCallback.reset();
             })
@@ -136,7 +139,7 @@ void MapRenderer::render(JNIEnv&) {
     renderer->render(*params);
 
     // Deliver the snapshot if requested
-    if (snapshotCallback && !paused) {
+    if (snapshotCallback) {
         snapshotCallback->operator()(backend->readFramebuffer());
         snapshotCallback.reset();
     }
@@ -174,14 +177,6 @@ void MapRenderer::onSurfaceChanged(JNIEnv&, jint width, jint height) {
     requestRender();
 }
 
-void MapRenderer::onResume(JNIEnv&) {
-    paused = false;
-}
-
-void MapRenderer::onPause(JNIEnv&) {
-    paused = true;
-}
-
 // Static methods //
 
 jni::Class<MapRenderer> MapRenderer::javaClass;
@@ -200,11 +195,7 @@ void MapRenderer::registerNative(jni::JNIEnv& env) {
                                          METHOD(&MapRenderer::onSurfaceCreated,
                                                 "nativeOnSurfaceCreated"),
                                          METHOD(&MapRenderer::onSurfaceChanged,
-                                                "nativeOnSurfaceChanged"),
-                                         METHOD(&MapRenderer::onResume,
-                                                "nativeOnResume"),
-                                         METHOD(&MapRenderer::onPause,
-                                                "nativeOnPause"));
+                                                "nativeOnSurfaceChanged"));
 }
 
 MapRenderer& MapRenderer::getNativePeer(JNIEnv& env, jni::Object<MapRenderer> jObject) {

diff --git a/platform/android/src/map_renderer.hpp b/platform/android/src/map_renderer.hpp
@@ -98,10 +98,6 @@ class MapRenderer : public Scheduler {
 
     void onSurfaceChanged(JNIEnv&, jint width, jint height);
 
-    void onResume(JNIEnv&);
-
-    void onPause(JNIEnv&);
-
 private:
     GenericUniqueWeakObject<MapRenderer> javaPeer;
 
@@ -124,7 +120,7 @@ class MapRenderer : public Scheduler {
     std::mutex updateMutex;
 
     bool framebufferSizeChanged = false;
-    std::atomic<bool> paused {false};
+    std::atomic<bool> destroyed {false};
 
     std::unique_ptr<SnapshotCallback> snapshotCallback;
 };