[core] Add changes to respect minzoom and maxzoom

This adds only the changes made in #5828 to address the issue where the style zoom levels were not respected when deciding when to render a layer.
mapbox · Jul 29, 2016 · e643ffe · 1ec5 · Jul 29, 2016 · tmpsantos
1 parent 85183dd
commit e643ffe
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/mbgl/style/layer_impl.cpp b/src/mbgl/style/layer_impl.cpp
@@ -11,9 +11,12 @@ bool Layer::Impl::hasRenderPass(RenderPass pass) const {
     return bool(passes & pass);
 }
 
-bool Layer::Impl::needsRendering() const {
-    return passes != RenderPass::None && visibility != VisibilityType::None;
-}
+bool Layer::Impl::needsRendering(float zoom) const {
+        return passes != RenderPass::None
+        && visibility != VisibilityType::None
+        && minZoom <= zoom
+        && maxZoom >= zoom;
+    }
 
 } // namespace style
 } // namespace mbgl
diff --git a/src/mbgl/style/layer_impl.hpp b/src/mbgl/style/layer_impl.hpp
@@ -59,7 +59,7 @@ class Layer::Impl {
     bool hasRenderPass(RenderPass) const;
 
     // Checks whether this layer can be rendered.
-    bool needsRendering() const;
+    bool needsRendering(float zoom) const;
 
     virtual float getQueryRadius() const { return 0; }
     virtual bool queryIntersectsGeometry(

diff --git a/src/mbgl/style/style.cpp b/src/mbgl/style/style.cpp
@@ -212,7 +212,7 @@ void Style::recalculate(float z, const TimePoint& timePoint, MapMode mode) {
         hasPendingTransitions |= layer->baseImpl->recalculate(parameters);
 
         Source* source = getSource(layer->baseImpl->source);
-        if (source && layer->baseImpl->needsRendering()) {
+        if (source && layer->baseImpl->needsRendering(z)) {
             source->enabled = true;
             if (!source->loaded && !source->isLoading()) {
                 source->load(fileSource);