-
Notifications
You must be signed in to change notification settings - Fork 1.3k
mapView:cameraDidChange:animated:
called repeatedly after shape source set to nil
#11180
Comments
mapView:cameraDidChange:animated:
called repeated after shape source set to nil
mapView:cameraDidChange:animated:
called repeatedly after shape source set to nil
It’s unexpected that merely changing a source’s data ( /cc @asheemmamoowala |
Is this the same issue or underlying cause as #10941? |
@jmkiley Been doing some digging, and this is my reading: Doing That calls the update lambda that has previously been set up by There are a couple of solutions that might work:
@jfirebaugh Pretty sure this is a duplicate of #10941. /cc @asheemmamoowala |
#10941 (comment) indicates that this is a regression introduced in v3.7.x. Did the logic around transitions in mbgl change in v3.7.0? |
Given the reports of this working correctly in v3.6.x, we should bisect between v3.6.x and v3.7.0 to find out what introduced the regression. |
Relatedly, #5833 is about infinite recursion caused by setting the camera within a camera change’s completion handler. |
Fixed in #11614. Closing. |
Platform: iOS
Mapbox SDK version:
master
Steps to trigger behavior
mapView:regionDidChange:animated:
.Expected behavior
For the layer that uses the shape source to be updated to contain no shapes.
Actual behavior
cameraDidChange
is called repeatedly, and there is an infinite loop. This does not seem to occur when the shape source is set tonil
in another method (such as in response to a tap gesture), or when the shape property is updated wit aMGLShape
object.I have reproduced this issue in
iosapp
.cc @julianrex @friedbunny
The text was updated successfully, but these errors were encountered: