-
Notifications
You must be signed in to change notification settings - Fork 1.3k
groupByLayout erroneously groups two layers with different layout expressions #11451
Comments
@jfirebaugh this is a bit hacky, but we could handle the edge case by wrapping the converted function expression with Another option is to translate old-style functions that include an explicit default value as |
There are four cases where
The complexity of converting |
Oy, yeah I forgot about the |
#11452 simply ignores the edge case. It seems unlikely to matter in practice. |
These two layers will be placed into the same group, even though they have different
icon-size
expressions:This is because
groupByLayout
stringifies layout values, and the stringification code hasn't been updated for expressions. I noticed it while working on #11247.We can switch over to stringifying the expression, which is possibly the result of converting an old-style function. However, this leaves an edge case: we don't include the
default
value in the conversion logic (it's handled during evaluation instead). So two old-style functions that were alike in everything exceptdefault
would be treated as if they were identical for the purposes of grouping layers.cc @anandthakker
The text was updated successfully, but these errors were encountered: