Including direction in setVisibleCoordinates calculates the viewport incorrectly

[TimWatson]

If you include direction when setting the visible coordinates it calculates the viewport first and then rotates the map resulting in an incorrect viewport.

Example:

var coordinates = [CLLocationCoordinate2D(latitude: 34.407548, longitude: -119.8696609),
							   CLLocationCoordinate2D(latitude: 34.4211754, longitude: -119.8394465)]
let padding = UIEdgeInsets(top: 10, left: 10, bottom: 10, right: 10)
let direction = CLLocationDirection(90)
let animation = CAMediaTimingFunction(name: kCAMediaTimingFunctionEaseInEaseOut)
mapView.setVisibleCoordinates(&coordinates, count: UInt(coordinates.count), edgePadding: padding, direction: direction, duration: 0.4, animationTimingFunction: animation, completionHandler: nil)

iOS 11.4
Mapbox 4.0.1, 4.0.2

mapbox-gl-native/platform/ios/src/MGLMapView.h

Line 762 in 43efd61

- (void)setVisibleCoordinates:(const CLLocationCoordinate2D *)coordinates count:(NSUInteger)count edgePadding:(UIEdgeInsets)insets direction:(CLLocationDirection)direction duration:(NSTimeInterval)duration animationTimingFunction:(nullable CAMediaTimingFunction *)function completionHandler:(nullable void (^)(void))completion;

[julianrex]

Thanks for the report @TimWatson

[stale]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

[TimWatson]

lol what. Does that mean this isn't getting fixed?

[julianrex]

Still on our list!

[fabian-guerra]

Hi @TimWatson. Thank you for using Mapbox. When you start the map it has a direction = 0 (north according to the docs). If you set the direction to 90 degrees then it will rotate to the east. If you require that the map view keep it's direction I suggest use:

mapView.setVisibleCoordinates(&coordinates, count: UInt(coordinates.count), edgePadding: padding, direction: mapView.direction, duration: 0.4, animationTimingFunction: animation, completionHandler: nil)

[TimWatson]

Hi Fabian, thanks for getting back to me. I need both the direction and the visible bounds to change but when using this function it currently calculates the new map bounds to fit the required visible bounds and then it applies the rotation. That means that the calculation is now wrong since the required visible bounds now fit differently in the new, rotated, map viewport. Your suggestion doesn't solve this issue.

[fabian-guerra]

Fixed in #13761