This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Fix wrong coordinates bounds when setting direction. #13761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
added
the
needs changelog
fabian-guerra
force-pushed
the
fabian-camera-12075
branch
from
bf1a366 to
2aad3f7
Compare
fabian-guerra
removed
the
needs changelog
friedbunny
reviewed
Jan 22, 2019
friedbunny
approved these changes
Jan 22, 2019
| @@ -3324,12 +3324,10 @@ - (void)_setVisibleCoordinates:(const CLLocationCoordinate2D *)coordinates count | |||
| { | |||
| latLngs.push_back({coordinates[i].latitude, coordinates[i].longitude}); | |||
| } | |||
|
|
|||
| CLLocationDirection cameraDirection = direction >= 0 ? direction : 0; | |||
There was a problem hiding this comment.
What you have now is probably more readable, but something like fmaxf(direction, 0) would also work.
fabian-guerra
force-pushed
the
fabian-camera-12075
branch
from
2aad3f7 to
6c53c32
Compare
fabian-guerra
force-pushed
the
fabian-camera-12075
branch
from
6c53c32 to
12ca8f7
Compare
1ec5
reviewed
May 2, 2019
| @@ -3326,12 +3326,10 @@ - (void)_setVisibleCoordinates:(const CLLocationCoordinate2D *)coordinates count | |||
| { | |||
| latLngs.push_back({coordinates[i].latitude, coordinates[i].longitude}); | |||
| } | |||
|
|
|||
| CLLocationDirection cameraDirection = direction >= 0 ? direction : 0; | |||
There was a problem hiding this comment.
This change is inconsistent with the meaning of negative direction elsewhere in the SDK. Negative values should correspond to self.direction: #14574.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12075