Render test integration: intermediate results

[tobrun]

Follow up from the node render test suite integration on Android in #12041. There is still some work left to get them fully working. There are currently 78 tests failing of the 607 executed tests. Would love some input from @mapbox/gl-core so we can cut down on the amount of failed tests.

Results

test	actual	expected	output
background-pattern pitch
background-pattern rotated
background-color colorspace-hcl
background-pattern @2x
fill-pattern uneven-pattern
hillshade-accent-color zoom-function
line-pattern overscaled
combinations line-translucent--fil-translucent
combinations-hilldshade-line-translucent

Notes:

• Most tests fail due to having either a bearing or pitch value in the style.json (shown in first two images)
• Some tests fail due to having a test property that isn't supported yet on Android (not listed above)

[jfirebaugh]

background-pattern pitch and background-pattern rotated look most like a legit bug -- like the map is just ending up with the wrong pitch and bearing values.

background-color colorspace-hcl looks like some sort of colorspace transformation bug.

hillshade-accent-color zoom-function and combinations-hilldshade-line-translucent have the same issue with seams, presumably on a tile edge.

The other ones look like floating point issues, e.g. with fill-pattern uneven-pattern the pattern is shifted vertically a tiny amount.

[lilykaiser]

Catching up here, what's the best next step? Should background-pattern pitch and background-pattern rotated and background-color colorspace-hcl be ticketed as gl core bugs?

[riastrad]

When using .addMarker() for bitmap icon placements, variation between color rendering for different devices has been observed. Here's a quick comparison that's been submitted, where POIs are more red on one device and more orange on another device:

HTC U11:

Samsung Galaxy S7

[kkaefer]

@riastrad that looks like some Android devices internally apply color space transformations, while others don't. Could you please send me the original spritesheet?

[riastrad]

@kkaefer in the above example, the icons aren't generated using a sprite-sheet, but are applied individually using different url calls. Here's the main one:

Let me know if you need more than this.

[kkaefer]

Thank you for providing this image. It looks like the color discrepancies you're seeing might be due to the gAMA/cHRM chunks in this particular image:

You could try removing these to ensure uniform interpretation on all devices. I ticketed a further investigation into this issue in #12560; please continue discussion there if necessary as this ticket is actually about a different issue.

[stale]

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.