Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Android: Handle color profiles/calibration when decompressing images #12560

Open
kkaefer opened this issue Aug 7, 2018 · 5 comments
Open

Android: Handle color profiles/calibration when decompressing images #12560

kkaefer opened this issue Aug 7, 2018 · 5 comments
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl

Comments

@kkaefer
Copy link
Member

kkaefer commented Aug 7, 2018

In
#12095 (comment), @riastrad reported color discrepancies for the same image on various Android devices. I suspect that they're due to the gAMA/cHRM chunks in this particular image:
image

We should ensure that all images are decompressed in the same way on all devices.

@kkaefer kkaefer added Android Mapbox Maps SDK for Android Core The cross-platform C++ core, aka mbgl labels Aug 7, 2018
@stale stale bot added the archived Archived because of inactivity label Feb 4, 2019
@stale
Copy link

stale bot commented Feb 5, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Feb 5, 2019
@riastrad
Copy link
Contributor

riastrad commented Feb 5, 2019

This still needs to happen, as it effects a few apps. Will post additional info for debugging shortly.

@riastrad riastrad reopened this Feb 5, 2019
@stale stale bot removed archived Archived because of inactivity labels Feb 5, 2019
@riastrad
Copy link
Contributor

riastrad commented May 6, 2019

Some long overdue context on this issue. Here's an icon that can be used to replicate the discrepancy that's been observed:
image

Here is a side-by-side comparison of the observed discrepancy:

☝️ screenshot from a HTC U11 running Android 8.0.0

☝️ screenshot from a Samsung Galaxy S7 running Android 7.0

As you can see from the screenshots, the icons appear to be slightly darker on the HTC U11 than they are on the Samsung Galaxy S7.

@stale stale bot added the archived Archived because of inactivity label Nov 2, 2019
@stale
Copy link

stale bot commented Nov 2, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 2, 2019
@kkaefer kkaefer reopened this Nov 3, 2019
@stale stale bot removed the archived Archived because of inactivity label Nov 3, 2019
@stale stale bot added the archived Archived because of inactivity label May 1, 2020
@stale
Copy link

stale bot commented May 1, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed May 1, 2020
@riastrad riastrad reopened this May 1, 2020
@stale stale bot removed the archived Archived because of inactivity label May 1, 2020
@stale stale bot added the archived Archived because of inactivity label Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

No branches or pull requests

2 participants